Fix build with Go v1.22.1, liboqs v0.10.0 #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In cc453db4a6e02d97bf5fc974840ace881ffa6da1 of liboqs, NIST KAT random helpers were removed from the public API interface of liboqs, causing liboqs-go to fail to build. Remove these functions as there's no way to support them anymore (and likely don't have much value). Signed-off-by: Alexander Scheel <[email protected]>
This uses fmt.Sprintf("%v", ...) to format numbers; per newer Go
toolchain versions:
> conversion from int to string yields a string of one rune,
> not a string of digits (did you mean fmt.Sprint(x)?)
This fixes `go test ./...`.
Signed-off-by: Alexander Scheel <[email protected]>
|
Thank you @vsoftco! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the build with newer toolchain, liboqs versions:
liboqs v0.10.0 drops support for the NIST KAT Random source in open-quantum-safe/liboqs@cc453db from the public API.
This also fixes some places in the test suite where
go test ./...fails due to callingstring(...)on Go 1.22.1: